joergbuchwald / ogs6py

Python-API for the OpenGeoSys (http://www.opengeosys.org) software.
BSD 3-Clause "New" or "Revised" License
16 stars 23 forks source link

Running a container with ogs6py #24

Closed jbathmann closed 3 years ago

jbathmann commented 3 years ago

https://github.com/joergbuchwald/ogs6py/blob/41d5424e565f16d3b47be6f85258fd5b64728cd1/ogs6py/ogs.py#L489

I either did not understand this line/the ogs6py usage using ogs in a singularity container, or there might be a bug here. As the code is checking, if singularity is installed, this line could be skipped and L490 could read:

if shutil.which("singularity") is None:

instead. At least, the current implementation does not work for me and I think the reason is given above.

jbathmann commented 3 years ago

Nevermind, the problem were my reading comprehension skills ;-)