joerghoh / cq5-healthcheck

CQ5 Healthcheck code
Apache License 2.0
28 stars 15 forks source link

Find a more generic way to parse and evaluate configured MBean comparison #32

Open mhaack opened 11 years ago

mhaack commented 11 years ago

Currently MBeanStatusProvider.compareAttributeValue(String, String, Object) has a dedicated check each different data type. Each supports a different set of comparison types and only some support arrays/lists. This leads to many lines of duplicated code and isn't very robust.

My suggestion is, we should find a more generic and robust way to check the configured MBean comparison. May be with the help of regex or an additional library.