search

joerghoh / cq5-healthcheck

CQ5 Healthcheck code
Apache License 2.0
28 stars 15 forks source link

Default /content/statuspage.html to install with vault. #37

Closed bobpaulin closed 11 years ago

bobpaulin commented 11 years ago

Currently the filter.xml does not install the /content/statuspage.html file to jcr. This should be added or perhaps a separate vault package should be created for the content.

joerghoh commented 11 years ago

Paul,

thank you very much for your code contribution. I really appreciate that.

I totally agree to your first commit (update vlt filter to add the statuspage) and I already merged it to master. But I hesitate to merge all, as they cover many aspects:

Can you create for each of these changesets a dedicated pull request? That would make the discussion much more easy.

Thanks again for your work, Jörg

alexsaar commented 11 years ago

@joerghoh I also implemented a page props dialog for multi page support in #9.

not sure though what the purpose of the server entry widget is. @bobpaulin can you provide more details?

for the status page in the vlt filter: I actually think we should move the status page and all the sample configs into a separate sample content package. in the end they are just this: samples. This package then could also contain a sample user to access the page in an author environment.

bobpaulin commented 11 years ago

@joerghoh Sorry for confusion. I should have moved the subsequent commits into a separate branch. This pull request was just for the vault filter change.

The additional commits are related to a few things.

The user: The OOTB CQ author install does not allow anonymous access at the sling level. So even if we add acls to the statuspage.html this page will require an authentication. So I added a user to allow a VIP or other monitoring software to call the page with an HTTP Basic Authentication.

The Server Entry Stuff. Often in CQ environments it is appropriate to take publishers or authors out of rotation for maintenance or code changes. The server entry widget and subsequent changes to the jsp are to support an author going in and setting a server as enabled or disabled and then publishing the file out. The logic in the JSP checks the Server Name that the page runs on and if it sees the Server is disabled it modifies the overall status.

Moving the page from content to etc This felt like a more conventional spot for the status page since it is more of a tool that would not expect to be published outside of a companies network.

Again I didn't mean for the other changes to get added to the pull request just the vault update. But if any of the others seem like they might be useful to integrate I can separate them into different branches to avoid this confusion in the future.

bobpaulin commented 11 years ago

Also +1 on moving the sample page into a different vault package. I'm going to close this issue to separate the things out.