search

joerghoh / cq5-healthcheck

CQ5 Healthcheck code
Apache License 2.0
28 stars 15 forks source link

Move sample page into it's own module. #38

Closed bobpaulin closed 11 years ago

bobpaulin commented 11 years ago

Sample page should be installed separately from the application code.

joerghoh commented 11 years ago

Hm, a dedicated module just for this single page? Sounds a bit overkill ...

What else should be put there?

bobpaulin commented 11 years ago

Could also stub out some additional popular OSGi configs. Additionally if any configurations were ever stored at the page level having a couple of different sample pages might be interesting. Perhaps a sample page is not really even necessary. Authors should create the page in the directory that they see fit.

alexsaar commented 11 years ago

I think all provider configurations except for those that are required for basic installation and setup should go into a separate package. This makes management of subsequent releases and their installation much easier for all environments that have their own configs (or removed own configs).

joerghoh commented 11 years ago

If we move the statuspage, we should move the page component for it as well. @Bob: Can you add this to your changeset and redo the pull request then?

@Alex: Let's move the discussion about the configs to a different thread.

alexsaar commented 11 years ago

merged the changes into the master and also moved configs into the sample content package. with this now we have a clean app package that only installs the actual application and people can start with that and create their own setup. if someone wants to start with a sample config and setup he can install the sample content package to see how the app can be used.