joergreichert / spray

Automatically exported from code.google.com/p/spray
1 stars 2 forks source link

Reduce plugin dependencies of Spray diagram plugin #131

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The code produced by the Shapes and Styles generator produces classes that 
implement framework interfaces/classes that are part of the DSL plugins. This 
currently means that the produced diagram plugin must have a dependency on the 
Shape/Style DSL plugins themselve.

The produced code must be independent of the language implementation. For 
runtime framework classes the o.e.s.runtime.* plugins are there. 

These framework classes must be moved to org.eclipselabs.spray.runtime.graphiti:
- ISprayStyle
- DefaultSprayStyle
- ISprayShape
- DefaultSprayShape

Code generator templates must be adjusted.

Original issue reported on code.google.com by karsten....@googlemail.com on 7 May 2012 at 7:26

GoogleCodeExporter commented 9 years ago
Need also to move these classes:
- ISprayConnection
- DefaultSprayConnection
- ISprayShapeConstants
- SprayLayoutManager

Changed generator templates:
- StyleGenerator
- GeneratorShapeDefinition
- GeneratorConnectionDefinition

Changed project wizard to not include the DSL plugins in the manifest of newly 
generated projects. (SprayProjectCreator)

Further figured out that a dependency to org.eclipse.xtext.ui only exists 
because we need 1 class from it. Copied 
AbstractGuiceAwareExecutableExtensionFactory and removed dependency.

Original comment by karsten....@googlemail.com on 7 May 2012 at 8:26

GoogleCodeExporter commented 9 years ago
Dependency to org.eclipse.xtext.ui is also needed for other purposes (e.g. 
IURIEditorOpener), need to leave the dependency.

Original comment by karsten....@googlemail.com on 7 May 2012 at 8:33

GoogleCodeExporter commented 9 years ago
Consolidated constants from ISprayShapeConstants into ISprayConstants. One 
interface is enough.

Original comment by karsten....@googlemail.com on 7 May 2012 at 8:43

GoogleCodeExporter commented 9 years ago
Code refactoring finished.

Original comment by karsten....@googlemail.com on 14 May 2012 at 7:37