joergschultzelutter / mpad

Multi-Purpose APRS Daemon (MPAD)
GNU General Public License v3.0
52 stars 5 forks source link

Input parser needs update on CWOP-by-id parser update #1

Closed joergschultzelutter closed 3 years ago

joergschultzelutter commented 3 years ago

Current code cannot be reached

joergschultzelutter commented 3 years ago

The input parser can't reach the cwop-by-cwop_id branch as a cwop ID is very likely to match a regular call sign without ssid. This means that the parser will recognise the 'cwop' command but assumes that the given identifier for the CWOP station is actually a ham radio call sign. Fortunately, aprs.fi is capable to return that CWOP ID's lat/lon coordinates, thus allowing MPAD to return the CWOP data based on geographical data (and not on the initial ID).

Obviously, this approach does not work as initially intended. However, as there is no universal distinction when it comes to distinguishing global call signs from CWOP IDs and the program is still capable to return the desired result to the user, I will not change this section for now.

tl;dr:

--> Potentially, CWOP lookups can be migrated from findu.com to aprs.fi. The aprs.fi API misses two things: metric/imperial settings and 'find cwop near lat/lon'. Migration is possible if the 'near lat/lon' option on aprs.fi is available.