joerncodes / obsidian-expiring-notes

Expiring Notes is a plugin for Obsidian, enabling you to automatically delete or archive notes after a pre-set date.
20 stars 1 forks source link

Mass delete? #1

Open kmaustral opened 2 years ago

kmaustral commented 2 years ago

This may not be the fault of this plug-in, but I found that all of my files were being deleted until I disabled this plug-in in BRAT. It seems a great idea but may best be used after testing and available on community plug-ins.

joerncodes commented 2 years ago

That is strange and obviously not the point of the plugin. Can you give me some background so I can maybe reproduce the error? Did you set the expiry dates yourself or with the command? What operating system are you on? I'd love to fix your problem as soon as possible!

kmaustral commented 2 years ago

I hadn't yet set any expiry dates yet. It may not be directly related to your plug-in. But it seemed to stop when I removed it. I'm on Windows and also sync to Linux. I noticed something wrong first when I couldn't open DNP. The folder location in the Daily Notes was red, even though the folder was still on my system. I couldn't open any Daily Note. Then I checked the sync and saw a stream of files being deleted.

On Mon, 22 Nov 2021 at 22:00, Jörn @.***> wrote:

That is strange and obviously not the point of the plugin. Can you give me some background so I can maybe reproduce the error? Did you set the expiry dates yourself or with the command? What operating system are you on? I'd love to fix your problem as soon as possible!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joerncodes/obsidian-expiring-notes/issues/1#issuecomment-975401701, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTR6N7URSUMDVYF7B5HX4TUNIPDDANCNFSM5IQKYQVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

joerncodes commented 2 years ago

Hm, that is indeed strange. In my tests, the plugin didn't touch files without an expiry date. The collector only finds files that a) have frontmatter in Obsidian and b) have a frontmatter key called expires (or whatever you set it to in settings).

Do you think it's possible the files got deleted by something external and were then sync'ed over?

kmaustral commented 2 years ago

Yes, I think it is possible. But just that it seemed to stop when I disabled your plugin. It could have been a coincidence. Hopefully, it's nothing to do with your plugin. I'll install it again if there's been no other reports over the next couple of weeks.

On Thu, 25 Nov 2021 at 01:31, Jörn @.***> wrote:

Hm, that is indeed strange. In my tests, the plugin didn't touch files without an expiry date. The collector only finds files that a) have frontmatter in Obsidian and b) have a frontmatter key called expires (or whatever you set it to in settings).

Do you think it's possible the files got deleted by something external and were then sync'ed over?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joerncodes/obsidian-expiring-notes/issues/1#issuecomment-977933116, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTR6N3LL7QGALG3K4NLPPLUNTZLXANCNFSM5IQKYQVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

joerncodes commented 2 years ago

That would indeed be a weird coincidence. I'll do some more tests, and I'll also make sure to ask for more people to beta test in the Discord. Thank you for your input, I hope the error doesn't occur again.