search

joernroeder / piwik-react-router

Piwik analytics component for react-router
https://www.npmjs.org/package/piwik-react-router
MIT License
61 stars 22 forks source link

Added support for spesifiy full url #24

Closed gerhardsletten closed 7 years ago

gerhardsletten commented 7 years ago

Hi, have a use-case where where piwik is running on ssl, but the frontend app is not (in dev-mode), so added the possibility to specify http/https in the url

joernroeder commented 7 years ago

Hey, yes, this looks like a tiny but necessary improvement when switching between http/https in development and production. Would you mind adding a note to the readme which explains the change?

gerhardsletten commented 7 years ago

@joernroeder Now it should be added

joernroeder commented 7 years ago

@gerhardsletten hey cool, thanks! i've published a new version to npm as well!

gerhardsletten commented 7 years ago

Great, thanks

G

On 29 Sep 2016, at 13:26, Jörn Röder notifications@github.com wrote:

@gerhardsletten https://github.com/gerhardsletten hey cool, thanks! i've published a new version to npm as well!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joernroeder/piwik-react-router/pull/24#issuecomment-250440385, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD3cA3oO3ch6AfECC2IITrm2g2kpaxnks5qu6B0gaJpZM4KImew.