search

joernroeder / piwik-react-router

Piwik analytics component for react-router
https://www.npmjs.org/package/piwik-react-router
MIT License
61 stars 22 forks source link

Handle basename in location object #28

Closed LubergAlexander closed 7 years ago

LubergAlexander commented 7 years ago

react-router supports useBasename which sets basename property on the location object. It's value should be used to construct the full path before sending data to Piwik. Also I have downgraded the history peerDependency version to be in sync with react-router, since react-router doesn't support version 4.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ada350e24335f9ca3ae20227a165adb563783c6f on LubergAlexander:master into 9eec4c11e885d9412c96b799299b08d3a45a456c on joernroeder:master.

joernroeder commented 7 years ago

Thanks for fixing this! I'll publish a new release...

joernroeder commented 7 years ago

done.

LubergAlexander commented 7 years ago

👍