search

joernroeder / piwik-react-router

Piwik analytics component for react-router
https://www.npmjs.org/package/piwik-react-router
MIT License
61 stars 22 forks source link

Updated dependencies to allow history 4.x #32

Closed jthomaschewski closed 7 years ago

jthomaschewski commented 7 years ago

It seems as if this package does still work fine with react-router@^4.0.0 + history@4.0.0 At least I haven't experienced any problems yet with a piwik-react-router+redux+react-router-redux... setup.

As the peerDependency is locked to ^3.0.0, it breaks npm install for me. That why I've created this trivial PR.

There still might be incompatibilities. I haven't thoroughly tested the package against history v4

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3e19d53c04f6b3af9c8dd5a4c4b76b0861c38109 on jbbr:master into 835dafd3cce8608438ffaa75b8acea618206e9a0 on joernroeder:master.

joernroeder commented 7 years ago

@jbbr thanks for opening this pull request – updating the package to history v4 stands on my (never ending) todo-list for a while now. I don't see any problem or incompatibility (coverage looks good and is at it's maximum) and will release it as version 0.8.0.

joernroeder commented 7 years ago

release 0.8.0 is live on npm :)