Optionally disable injection of piwik script

joernroeder / piwik-react-router

Piwik analytics component for react-router

https://www.npmjs.org/package/piwik-react-router

MIT License

61 stars 22 forks source link

Optionally disable injection of piwik script #33

Closed tbtz closed 7 years ago

tbtz commented 7 years ago

Added an option to disable the injection of the piwik.js script into DOM. Also added tests for the option. Default: Injection enabled.

CAUSES:

We need to load the script separately to:

prevent uncontrollable side effects
prevent multiple loading if script already exists
make loading of the script configurable

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling c9daab1ec7367ac9ee35ca6e6983d3cbc651a8ba on tbtz:optional-piwik-injection into 2510ae2e4083e5538758a6389d035d182aec7695 on joernroeder:master.

joernroeder commented 7 years ago

thanks for submitting your idea, code and tests 👍. Would you mind adding the option to the documentation as well. I'll merge it into master afterwards.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling cf26eec120537cdf6ef4f4a3ae33ee4e19b5aebd on tbtz:optional-piwik-injection into 2510ae2e4083e5538758a6389d035d182aec7695 on joernroeder:master.

tbtz commented 7 years ago

Added the option to the documentation :blush::+1:

joernroeder commented 7 years ago

thanks for your contribution. i've pushed a new 0.8.2 version to npm.