search

joernroeder / piwik-react-router

Piwik analytics component for react-router
https://www.npmjs.org/package/piwik-react-router
MIT License
61 stars 22 forks source link

add alreadyInitialized option which skips piwik initialization #42

Closed swergas closed 7 years ago

swergas commented 7 years ago

Naive fix for https://github.com/joernroeder/piwik-react-router/issues/41

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 55a93a216a23fd3058bef33b47f989f1059196a8 on assembl:skip_piwik_initialization into 999fe4b450818393d375e13dce418230c31483f5 on joernroeder:master.

sapegin commented 7 years ago

@swergas @joernroeder How can I help to get this merged? Have a similar issue.

joernroeder commented 7 years ago

@swergas @sapegin

i've looked at this today and propose another pull request which introduces a dynamic "already initialized" check #46 . would you mind to pull down the feature branch and give it a try?

joernroeder commented 7 years ago

@swergas thanks for contributing! I'm going to close this request for now as #46 builds on top of it. feel free to reopen this thread :)