search

joernroeder / piwik-react-router

Piwik analytics component for react-router
https://www.npmjs.org/package/piwik-react-router
MIT License
61 stars 22 forks source link

Auto inject script #54

Open fargerio opened 6 years ago

fargerio commented 6 years ago

As discussed in #48, injection fails if the document does not contain a script tag. (For example in test suites with jsdom)

This simply checks for presence of a script tag and appends a new script tag if none is found.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4eaca033f3c984105c1ccd47dcfd75a9b05dbb74 on Klimakoenner:auto-inject-script into 9e618ad27c5c60e421d15d45607783c0c4513742 on joernroeder:master.

joernroeder commented 6 years ago

hey, thanks for your contribution and looking into this! i never felt comfortable with my hack and will review this pr within the next days. i was simply to busy in the past few weeks.

cafca commented 4 years ago

Hey! I would really appreciate if you could merge this fix. Can I help with this in any way? @joernroeder