Add support for using with react-router v3 which uses history v3.

joernroeder / piwik-react-router

Piwik analytics component for react-router

https://www.npmjs.org/package/piwik-react-router

MIT License

61 stars 22 forks source link

Add support for using with react-router v3 which uses history v3. #55

Open walokra opened 6 years ago

walokra commented 6 years ago

The first tracking fails as it tries to look for page history.location which was added in history v4 and replaced history.getCurrentLocation() function in history v3.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 0370fdea3b71b37b3fba877860f168b958428106 on walokra:support-history-v3 into 9e618ad27c5c60e421d15d45607783c0c4513742 on joernroeder:master.

joernroeder commented 6 years ago

hey @walokra, thanks for your contribution. i would love to merge your changes but would please you to add an additional test to the suite to cover the following line https://coveralls.io/builds/17947610/source?filename=index.js#L185 as well as following code styles by ending lines with a ;. thanks!