Open emerencia opened 2 years ago
The exported typescript definition reads:
connectToHistory<H extends LooseHistory>(history: H): H;
But in react-router-piwik.js the function is defined as:
connectToHistory(history, trackAtConnect, callback)
I can supply those extra arguments and it works, but my IDE complains about a typescript mismatch:
I think at some point the function got extra arguments and someone forgot to update the typescript exported definition?
I even think that if you call it with just one argument, it errors, because it tries to call that callback function (third argument).
The exported typescript definition reads:
But in react-router-piwik.js the function is defined as:
I can supply those extra arguments and it works, but my IDE complains about a typescript mismatch:
I think at some point the function got extra arguments and someone forgot to update the typescript exported definition?
I even think that if you call it with just one argument, it errors, because it tries to call that callback function (third argument).