Closed jrwarwick closed 4 years ago
I would say we should get sounds out and leave it to the users to provide sounds! Can you make a PR for that?
The reason is, besides that we could get trouble providing original sound, it blows up the repository (audio and git don't like each other). But I am open for reasons to have some "cheese" placeholders in.
I understand, I will make a deletion PR. The place holders would only have value to make the gh-pages demo easier to manage, with full capability demonstrated.
--Justin
On Sat, Nov 16, 2019, 15:13 Jörn Weißenborn notifications@github.com wrote:
The reason is, besides that we could get trouble providing original sound, it blows up the repository (audio and git don't like each other). But I am open for reasons to have some "cheese" placeholders in.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joernweissenborn/lcars/issues/24?email_source=notifications&email_token=AALAR5HWY657BPNISSC72TTQUB5B5A5CNFSM4JOGX7VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEH4YAA#issuecomment-554683392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALAR5DP6YSQ2YQ4D35CQLLQUB5B5ANCNFSM4JOGX7VA .
I leave it to your judgment if your sounds could make copyright issues, but if you made them yourself there should be no issues and we could keep a few in for demo. In the end, people will not use the whole repo but only the min.css
Right, good point. Ok I will just leave in the few place holders for the easy demo. As you say, no threat since I just created them from scratch. Maybe I will just add a quick note about the renaming and the sites that might be good sources for users to collect from. Would be ok?
--Justin
On Sat, Nov 16, 2019, 15:43 Jörn Weißenborn notifications@github.com wrote:
I leave it to your judgment if your sounds could make copyright issues, but if you made them yourself there should be no issues and we could keep a few in for demo. In the end, people will not use the wholl repo but only the min.css
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joernweissenborn/lcars/issues/24?email_source=notifications&email_token=AALAR5HN37NIR54GFXXV3H3QUCAR7A5CNFSM4JOGX7VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEH5GBQ#issuecomment-554685190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALAR5E7XP7ZIIWCDMCU4GTQUCAR7ANCNFSM4JOGX7VA .
Perfect. A link should not hurt so fine with me.
Am So., 17. Nov. 2019 um 00:54 Uhr schrieb Justin Warwick < notifications@github.com>:
Right, good point. Ok I will just leave in the few place holders for the easy demo. As you say, no threat since I just created them from scratch. Maybe I will just add a quick note about the renaming and the sites that might be good sources for users to collect from. Would be ok?
--Justin
On Sat, Nov 16, 2019, 15:43 Jörn Weißenborn notifications@github.com wrote:
I leave it to your judgment if your sounds could make copyright issues, but if you made them yourself there should be no issues and we could keep a few in for demo. In the end, people will not use the wholl repo but only the min.css
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/joernweissenborn/lcars/issues/24?email_source=notifications&email_token=AALAR5HN37NIR54GFXXV3H3QUCAR7A5CNFSM4JOGX7VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEH5GBQ#issuecomment-554685190 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AALAR5E7XP7ZIIWCDMCU4GTQUCAR7ANCNFSM4JOGX7VA
.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joernweissenborn/lcars/issues/24?email_source=notifications&email_token=AARG7QPL5VC2H65OAHYPQYDQUCBZ7A5CNFSM4JOGX7VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEH5LOY#issuecomment-554685883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARG7QLA2KWH23JZJCT3B5LQUCBZ7ANCNFSM4JOGX7VA .
Previously, audio support was added and some totally inauthentic cheesy place holder sounds effects were included. I have gotten permission from The current owner of STdimension to use the collection of sfx, including renaming files, and distributing. He noted that it would be advisable to review liability, and to include disclaimer and attribution to CBS/Paramount if we do it. I'm in favor of this; it's not commerical, very minor sample and precedent exists for reuse.
If we don't do this, I could instead provide simple instructions, maybe even a script to "upgrade" the sounds to the authentic editions.
What do you think?