search

joernweissenborn / lcars

CSS Framework to style web pages like the fictional computer operating system of a popular sci-fi franchise.
http://joernweissenborn.github.io/lcars/
MIT License
334 stars 80 forks source link

Demo/doc left-hand side-bar navigation has too many buttons #64

Open jrwarwick opened 3 years ago

jrwarwick commented 3 years ago

With the adding of sections, the left-hand side bar now overflows on the bottom on not-too modestly sized screens (a laptop, in my case). Even though it reduces the flavor, I think we need to lose the "TOP" button and the "SRC" button. Or possibly if someone is feeling ambitious, move them to the bottom horizontal footer frame bar.

dthv commented 3 years ago

Moving them to the horizontal bars entails modifying the element's height. This is something @xenziffen managed to do in their fork (edit: cf. #53). Their solution should be integrated (and/or improved).

On the issue: For the future, it would be preferably if one finds a solution for overlong elements, esp. bars. This could entail "half-height" buttons (not exactly half, I'm afraid) that would also fit in the horizontal bars, also in vertical bars.

After master has been renamed into main (edit: cf. #63), I will open a PR to remove TOP/SRC for a quick fix.

xenziffen commented 3 years ago

I do encourage you to use/copy any useful changes from my fork. I attempted PRs then mothballed my local.

The color CSS specificity, horizontal bars and sweep transitions, and brackets were all adapted and I hope could be useful.

I stalled at audio element improvements and layout templates. I think I only made 3 standard layouts, and didn't revise the example content as much as needed.

On Thu, Dec 3, 2020, 13:41 dthv notifications@github.com wrote:

Moving them to the horizontal bars entails modifying the element's height. This is something @xenziffen https://github.com/xenziffen managed to do in their fork. Their solution should be integrated (and/or improved).

On the issue: For the future, it would be preferably if one finds a solution for overlong elements, esp. bars. This could entail "half-height" buttons (not exactly half, I'm afraid) that would also fit in the horizontal bars, also in vertical bars.

After master has been renamed into main, I will open a PR to remove TOP/SRC for a quick fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joernweissenborn/lcars/issues/64#issuecomment-738336264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3PFB4KEXISNDMT46X6N2LSTAAX3ANCNFSM4UMQ7PVQ .

jrwarwick commented 3 years ago

@xenziffen I have discovered that you will not be credited as a "contributor" by GitHub systems unless you file a PR. Indeed, I believe there are a few of your commits in there already (I must have branched off of your fork or something), which brought in your work on color specificity (three commits starting with aeec4897376801b496ac7b4ea77ec91c2dcd9dec from around the end of February), but that did not result your addition to the Contributors list.

If that doesn't matter to you, we'll certainly dig further into your work. Or perhaps you could find the simplest of your changes and create a simple, small PR that can be expedited, and that can stand for all of your contributions.