search

joeroe / risotto

A minimalist, responsive hugo theme inspired by terminal ricing aesthetics.
https://risotto.joeroe.io
MIT License
393 stars 109 forks source link

Enhancement: Adding target mode support to sociallinks #68

Closed tahacodes closed 5 months ago

tahacodes commented 5 months ago

Hey there,

Thank you for this awesome theme. I really appreciate the beauty and simplicity of it. ❤️

I made a minor change to the "layouts/partials/about.html" file, I added an option to specify the “target” attribute in the Hugo configuration file for social links. By default, the behavior remains as "_self" This means that if users don’t explicitly set a target, it will function just as before.

Thank you for considering this PR!

joeroe commented 5 months ago

Hmm, thanks, but I'm not convinced that this is worth the extra complexity of a config parameter. It's usually recommended to leave the user to decide in what context they want to open a link, but if you do need to make it _blank for some reason, you can always replace the theme's template with your own.

I think instead I'll abstract out the individual links to make them easier to override (#69). But thank you for the suggestion!