search

joerussbowman / gaeutilities

gaeutilities - A collection of utilities to help with application development on Google Appengine
http://gaeutilities.appspot.com
BSD 3-Clause "New" or "Revised" License
78 stars 4 forks source link

Session.clear() is broken #20

Closed dound closed 14 years ago

dound commented 14 years ago

Line 867 in sessions.py has an extraneous 's' character which causes Session.clear() to crash.

ERROR 2010-05-14 22:31:38,160 init.py:391] global name 's' is not defined Traceback (most recent call last): File "/usr/local/google_appengine/google/appengine/ext/webapp/init.py", line 511, in call handler.get(*groups) File "/home/dgu/projects/gae-sessions/demo-perf/main.py", line 42, in get session.clear() File "/home/dgu/projects/gae-sessions/demo-perf/appengine_utilities/sessions.py", line 868, in clear simplejson.dumps(self.cookie_vals) NameError: global name 's' is not defined

dound commented 14 years ago

I've patched the bug in a fork of your repo and made a pull request so that you can integrate the patch. Here's the commit on my fork: http://github.com/dound/gaeutilities/commit/62dc29f70af9ffa45475aedbdca603cdfa5876fa

joerussbowman commented 14 years ago

Patch has been applied, thanks

dound commented 14 years ago

No problem, though I don't see the patch in the repo yet (not sure if you meant to push it but didn't).

joerussbowman commented 14 years ago

I accepted the change, but for some reason it didn't apply. Not sure why. I went ahead and applied it manually (got to love the fact you can edit the source via the web interface on github) and made sure to attribute the changes were originally contributed by you. Thanks.