search

joerussbowman / gaeutilities

gaeutilities - A collection of utilities to help with application development on Google Appengine
http://gaeutilities.appspot.com
BSD 3-Clause "New" or "Revised" License
78 stars 4 forks source link

Touched up code to silence pyflakes warnings #25

Closed trammell closed 13 years ago

trammell commented 14 years ago

Used pyflakes (http://pypi.python.org/pypi/pyflakes) to locate and remove unnecessary imports.

joerussbowman commented 14 years ago

Have you tested to make sure this runs? For example your commit has removing the memcache import in sessions, and memcache is used.

trammell commented 14 years ago

Hm, how do I run the test suite?

joerussbowman commented 14 years ago

The application ships with the demo application, so you should be able to run it and then validate all the different links work just as they do in the demo online at gaeutilities.appspot.com

joerussbowman commented 14 years ago

Note: hit close by accident, reopened.

trammell commented 13 years ago

Just got back to this. I thought I had broken the app, but it turns out when I download the latest of yours from GitHub I get the same problem--going to /session gives me some sort of header corruption that borks the HTML. System is OpenSUSE/Python2.5/Firefox/GAE1.3.8. Will try testing on other platforms.

joerussbowman commented 13 years ago

Session sets headers and such to make sure nothing is cached. You need to load session before anything it output by your application request handler or you'll get that corruption.

trammell commented 13 years ago

Perhaps I was not clear; I see this issue on the demo site included in a vanilla checkout of your github repo.

joerussbowman commented 13 years ago

maybe something broke with recent gae upgrades. It's loading correctly on the live site though. http://gaeutilities.appspot.com/session

I'll see if I can scrounge up some time to take a look, but these days I rarely get to touch a computer any more at home, heck I wouldn't even keep up with email if it wasn't on my phone lol

trammell commented 13 years ago

Just verified same bug on MacOS 10.6. I'll see if I can determine why these headers are borked.