Added additional configuration options...

joeshaw / carwings

Go package and CLI tool for the Nissan Leaf Carwings API

MIT License

31 stars 11 forks source link

Added additional configuration options... #9

Closed winterhalder closed 5 years ago

winterhalder commented 5 years ago

I'm in Canada, and had to override some constants to get things to work. Thought it might be helpful if these were part of the configuration options instead of requiring folks to rebuilt.

The new options are:

timeout - timeout in seconds (60 seconds is way to short for access from Canada unfortunately). I set mine to 600!
url - the baseurl to use. I've been using https://gdcportalgw.its-mo.com/gworchest_160803EC/gdc/
intialappstrings - I haven't had to change that one, but seemed like a good addition for completeness

joeshaw commented 5 years ago

I’m trying the fixmie bot out, so don’t stress too much over fixing up its suggestions. but thanks for doing it this far

winterhalder commented 5 years ago

So - are you going to accept?

winterhalder commented 5 years ago

Or do I hit Close Pull Request - I honestly don't much understand the process :)

winterhalder commented 5 years ago

I guess I'll just maintain my own then?

joeshaw commented 5 years ago

I'm sorry, I haven't had an opportunity to review this. I am not opposed to the options.

joeshaw commented 5 years ago

I merged this branch with some modifications. I removed initialAppStrings as a configurable option, and made the timeout a Go time.Duration rather than an integer. See 5eff726e62a61cbf6035db365985a78c67c66163 and 7e897074c3a7837b153ab3e7cdbdddc9a0e08ca2.

winterhalder commented 5 years ago

Cool - just noticed you'd accepted/merged. Thanks! :)