joesinger12 / TestTicketTransfer

0 stars 0 forks source link

Cycling fan control for AirSystems #19

Open joesinger12 opened 9 years ago

joesinger12 commented 9 years ago

Originally created by: da...@360-analytics.com Originally owned by: kbe...@gmail.com

Add ability to cycle AirSystems (AirLoopHVAC).  Limit to Type = HV, SZAC/SZHP and SZVAVAC/SZVAVHP.

This will be accomplished in rules by setting the Fan schedule to "AllOff", and using the night cycle controller cycle the system on.

- Add new property, AirSystem:FanCtrl, with the following enums: Continuous, Cycling (same as ZnSys). - If FanCtrl = Continuous, the rules set AirSys:AvailSchRef as they currently do, and night cycle based on value of AirSys:NightCycleFanCtrl - If FanCtrl = Cycling, the rules set AirSys:AvailSchRef to 'AllOff' (0 for all hours), and sets AirSys:NightCycleFanCtrl = CycleOnAny, regardless of user input or other rules.

To provide better control over the night cycle behavior, KB to add support OS support and SDD translation for the following additional fields:

Thermostat Tolerance -> AirSys:NightCycleTstatTolerance Cycling Run Time - -> AirSys:NightCycleRunTime

For additional background, see comments on #21 and beyond of issue 940.

Reported by: joesinger12

Original Ticket: cbecc-com/tickets/1099

joesinger12 commented 9 years ago

Originally posted by: da...@360-analytics.com

This enhancement has been pushed to v4.

Instead of adding cycling control to AirSystems, a new ZoneSystem type will be added to support cycling single-zone AC/HP units, primarily for use with residential applications.  See GC Issue 1104 for information on the new system type.

Labels: -Priority-High -Milestone-ComV3c Priority-Low Milestone-ComV4 Status: Discussion

Original comment by: joesinger12

joesinger12 commented 9 years ago

Originally posted by: nka...@archenergy.com

(No comment was entered for this change.)

Labels: -Milestone-ComV4 Milestone-Com2016

Original comment by: joesinger12

joesinger12 commented 8 years ago

Original comment by: joesinger12

joesinger12 commented 8 years ago

5/26 DR - This enhancement has been pushed to v4.

Instead of adding cycling control to AirSystems, a new ZoneSystem type will be added to support cycling single-zone AC/HP units, primarily for use with residential applications. See GC Issue 1104 for information on the new system type.

Original comment by: joesinger12

joesinger12 commented 8 years ago

Kyle, This issue is on the list of possible issues to address in the next release.

I've created an example XML file to illustrate the revised inputs. Basically, all that is done is the system is scheduled to be 'Off' all the time, and we let the AM:NightCycle cycle the system 'On' as needed.

I think it works, except the default CycleRunTime of 3600 seconds makes this system run a lot more than I think is needed.

So, all that remains is adding SDD->OS translation of the two new properties I mentioned above for having more control over AM:NightCycle:

AirSys:NightCycleTstatTolerance -> Thermostat Tolerance AirSys:NightCycleRunTime -> Cycling Run Time

Can you also confirm that you have SDD -> OS translation for the following AirSys:NightCycleCtrl options:

StaysOff -> StaysOff CycleOnCallAnyZone -> CycleOnAny CycleOnCallPrimaryZone -> CycleOnControlZone, ControlZoneName = AirSysCtrlZnRef:Name CycleZoneFansOnly -> CycleOnAnyZoneFansOnly

Original comment by: joesinger12

joesinger12 commented 8 years ago

This issue is priority 3, but I'd like to get it included in the next release. Is this something that can be added in next day or two?

Original comment by: joesinger12

joesinger12 commented 8 years ago

Yes.

Original comment by: joesinger12

joesinger12 commented 8 years ago

David,

Currently the translation does not consider the value of AirSys:FanCtrl. Is there any reason that it should? It seems like you are taking care of the fan control in rules based on your night cycle manager settings (or lack of).

It looks like all I need to do is add support for the two new properties.

Note that independent of the cycling fan work, I also need to add support for "CycleOnCallPrimaryZone" because it is currently mapped to cycle on any, with a log that cycle on primary zone is not yet supported. (When that code was written we didin't have full access to the night cycle AVM in OpenStudio.)

Original comment by: joesinger12

joesinger12 commented 8 years ago

No, translation does not need to look at AirSys:FanCtrl. As you mentioned, I am setting the AvailSchRef to a new schedule that schedules the system off for all hours, and then setting the AM:NightCycle option.

So yes, all that is needed for intial testing is translation support for the two new properties and "CycleOnCallPrimaryZone".

Thanks!

Original comment by: joesinger12

joesinger12 commented 8 years ago

You make my life too easy!

Original comment by: joesinger12

joesinger12 commented 8 years ago

https://github.com/NREL/OpenStudio/commit/c844ce16dea104de46848ba3869163ac9c6d2369

Original comment by: joesinger12

joesinger12 commented 8 years ago

I do try to keep it simple. For one, I know you are a busy guy... But mostly because it gives me more flexibility on our side ;). Thanks for the updates, I post a summary of my testing here.

Original comment by: joesinger12

joesinger12 commented 8 years ago

KB- I am testing the update, and I am not seeing an AM:NightCycle being added to the idf despite the test SDD XML model (attached) indicating AirSys:NightCycleFanCtrl = CycleOnCallPrimaryZone. Can you take a look?

Original comment by: joesinger12

joesinger12 commented 8 years ago

stand by.

Original comment by: joesinger12

joesinger12 commented 8 years ago

Diff:

Original comment by: joesinger12

joesinger12 commented 8 years ago

Original comment by: joesinger12

joesinger12 commented 8 years ago

Disallowing cycling control fan for Air Systems was discussed on 4/26 however decision was made to not change the current implementation.

Original comment by: joesinger12

joesinger12 commented 7 years ago

Original comment by: joesinger12

joesinger12 commented 6 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Diff:


--- old
+++ new
@@ -0,0 +1 @@
+1099_OffLrg-PlenumsFPBsData19 - ap.xml (349.7 kB; text/xml)

Original comment by: joesinger12

joesinger12 commented 5 years ago

AVM:NightCycle has been reworked since we first used it in EPv8.5. Changing owner to Kyle for the following updates for the E+9.0 version of CBECC-Com reverse translator:

We are adding two new options for AirSys:NightCycleFanCtrl that will need to be translated:

CycleOnAnyCooling - If defined, populate list of 'Cooling Control Zone or Zone List Name' with the name of all ThrmlZns that reference this system in the model.

CycleOnAnyHeating - If defined, populate list of 'Heating Control Zone or Zone List Name' with name of all ThrmlZns that reference this system in the model.

Also, change the AirSys:NightCycleFanCtrl is defined in SDD, set E+ Cycling Run Time Control Type = ThermostatWithMinimumRunTime (is currently being set to FixedRunTime). The run time for this control will still be specified by the SDD property AirSys:NightCycleRunTime. Default to 5min (300sec) if not specified in SDD.

Attached is an example model with 5 AirSystems, each with a different NightCycle controller type, including the new 2 new ones listed above.

Original comment by: joesinger12

joesinger12 commented 5 years ago

Diff:


--- old
+++ new
@@ -1 +0,0 @@
-1099_OffLrg-PlenumsFPBsData19 - ap.xml (349.7 kB; text/xml)

Original comment by: joesinger12

joesinger12 commented 5 years ago

https://github.com/NREL/OpenStudio/commit/a60a567ae511605056c9215ab8fd7fd8a793cc16

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Some preliminary testing of using the new AVM:NightCycle option 'ThermostatWithMinimumRunTime' doesn't seem to complete resolve unmet load hours for AirSystems that are specified with cycling control. I evaluated a number of run times, and tstat tolerance combinations, and it did not address the problem. The night cycle controller just doesn't seem to hold the zone as close to the desired setpoint as a system that is controlled by other means. Recommend this be pushed to the E+ team for review

Original comment by: joesinger12

joesinger12 commented 1 year ago

Original comment by: joesinger12