search

joesinger12 / TestTicketTransfer

0 stars 0 forks source link

Two speed fans for ZnSys #68

Closed joesinger12 closed 2 months ago

joesinger12 commented 5 years ago

Some ZnSys's support TwoSpeed (VRF, FPFC), but others don't (SZHP, PTAC, etc). Update translator and rules to support modeling TwoSpeed for the other supported ZnSys Types

Reported by: joesinger12

Original Ticket: cbecc-com/tickets/2907

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Hi David,

It is my understanding that this is not possible via a generic change as there is not a FanTwoSpeed analog to FanConstantVolume. Instead, various components drive the FanConstantVolume at two or more speeds, but this is not available or applied consistently. For example FPFC has LowSpeedSupplyAirFlowRatio and MediumSpeedSupplyAirFlowRatio fields, but PTAC does not. PTAC does have SupplyAirFlowRateDuringCoolingOperation and SupplyAirFlowRateDuringHeatingOperation, but not multiple speeds within a mode.

All of this is to the best of my knolwedge, and your requests are always well researched so I'm wondering if you can clarify what you might have had in mind.

We can discuss on conference call.

Original comment by: joesinger12

joesinger12 commented 5 years ago

KB, For all of the ZnSys we support, I'd like to add translation for the following new property:

ZnSys:FanOperModeSchRef,

which would translate to Supply Air Fan Operating Mode Schedule Name. This will give us more control on how a system cycles or runs continuous during specific hours. You should already have some logic for setting this schedule, which I would like you to keep, but if this sch is specified, use it instead.

Also, for all of the ZnSys we use, with the exception of FPFC, I'd like to add translation for the following properties that are currently already translated for ZoneHVAC VRF:

ZnSys:ClgDsgnSupAirTemp ZnSys:HtgDsgnSupAirTemp ZnSys:ClgSupFanCapSim ZnSys:HtgSupFanCapSim ZnSys:NoClgSupFanCapSim ZnSys:NoHtgSupFanCapSim ZnSys:ClgOAFlowCapSim ZnSys:HtgOAFlowCapSim ZnSys:NoClgHtgOAFlowCapSim

You should already have some logic for setting these which I would like to you keep, but if these values are specified, use them instead.

The example file included with ticket 2869 covers these properties as well.

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

To my knoweldge most (all?) zone hvac does not have NoClgSupFanCap or NoHtgSupFanCap. Can you clarify?

Similarly,

ZnSys:ClgDsgnSupAirTemp ZnSys:HtgDsgnSupAirTemp

Look like Sizing:Zone properties to me. Can you clarify your intended maping?

Original comment by: joesinger12

joesinger12 commented 5 years ago

Oops, ZnSys:ClgDsgnSupAirTemp & ZnSys:HtgDsgnSupAirTemp were not supposed to be in this list...

You are right, PTAC, PTHP, and WSHP have Field: No Load Supply Air Flow Rate ...

Lets use these properties, the (xx) is new.

ZnSys:ClgSupFanCapSim ZnSys:HtgSupFanCapSim ZnSys:NoClgHtgSupFanCapSim (xx) ZnSys:ClgOAFlowCapSim ZnSys:HtgOAFlowCapSim ZnSys:NoClgHtgOAFlowCapSim

Original comment by: joesinger12

joesinger12 commented 5 years ago

done.

https://github.com/NREL/OpenStudio/commit/142ea82efdc4947569e94be3aab0fed6708313f0

Original comment by: joesinger12

joesinger12 commented 5 years ago

Kyle, I'd like to also make some additional, related changes to the current FPFC translation.

Currently, there is some logic to set Capacity Control and other FPFC inputs based on SDD terms. Want to change this to be more explicit and similar to other updates to ZnSys.

I've outlined the changes in the translation spreadsheet, see items in red ont he FPFC tab: https://docs.google.com/spreadsheets/d/1Tsu7bJflkZAKAm4-ELJ87JKAXCeTQse-L7m-T5JqCAE/edit#gid=3

As you can see, I'm adding a new property to the SDD to direct translation of the Capacity Control, and making the specification of other properties more transparent, so you'll be deprecating some old translation code here. Please keep the old code for future reference.

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Updates to BEMBase and rules committed r5868 of 2019-1-0_RC-DRDev branch.

Still need to enable two speed fans for ZnSys that now have this capability.

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

DR - The value of the Field: "Low speed supply air flow ratio" needs to be changed to Max(ZnSys:NoClgSupFanCapSim, ZnSys:NoHtgSupFanCapSim)/Field: Maximum Supply Air Flow Rate. This was a mistake on my part communicating the formula.

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

https://github.com/NREL/OpenStudio/commit/2a0d0cb806431d709df70edb106d0beaec7eed1b

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Original comment by: joesinger12

joesinger12 commented 5 years ago

Updates for this merged to trunk. Two speed fans, previously only supported for FPFC and VRF, are now supported for the following ZnSys:Types:

SZAC SZHP PTAC PTHP WSHP

In doing some last-minute testing, I found that the two speed fans are not being allowed. I have a fix but holding off on committing until after the 5/2 packaging.

Original comment by: joesinger12

joesinger12 commented 1 year ago

Original comment by: joesinger12