Closed justinabrahms closed 10 years ago
Wondering if we could just pass request as an extra parameter to get_queryset and not break backwards compat?
It's still a backwards incompatible change, because get_queryset
didn't necessarily take kwargs before. I can update the API to take kwargs so it'll be a bit easier going forward.
Well in that case, a change is a change, so i'm okay with it as is :+1:
This does a few things:
get_queryset
to take a request instead of an object. This is necessary to support things that span beyond user-based permissions. In Sprint.ly's case, user+product is the specific permission we want here, which isn't exposed without passing the full request, as it'll be in post data.