search

joethei / browser-link-favicons

See the favicon for a linked website.
GNU General Public License v3.0
13 stars 2 forks source link

Ignored pages error, no favicons #4

Open NomarCub opened 2 years ago

NomarCub commented 2 years ago

I tried using the extension on both Chrome and FireFox, but neither seemed to work. I used the plugin's page as a test: https://addons.mozilla.org/hu/firefox/addon/favicons-for-links/

The errors are different on either browser, but they point to the same place in code.

Chrome: image

Firefox: image

Also, would you provide a link in the readme to the site you use in your example picture? At this point, I have no idea how the sites I checked are supposed to look or if they are even supported, and I have nothing to compare them to.

joethei commented 2 years ago

Oh, I thought I fixed that error months ago. Go into the add-on settings, write something into the ignored pages field, save, and then remove it again.

The screenshot is from the References section of https://en.wikipedia.org/wiki/Firefox.

Most external links in websites should show a favicon, it might not look good everywhere, as the web is a way more complicated environment than Obsidian.

Firefox add-ons will not work on the add-on site itself, Mozilla explicitly blocks access to it.

I will try to fix this issue at some point, but time is limited with the new job and my BA thesis starting soonish.

NomarCub commented 2 years ago

It works, thanks! I found some things that work weirdly in the extensions (no apparent caching, thus slow loading, some errors on console, things looking generally weird sometimes). Should I hold off on reporting until after a potential refactor?

joethei commented 2 years ago

You can open issues for them so I don't forget any.