search

joethei / obsidian-link-favicon

See the favicon for a linked website.
GNU General Public License v3.0
91 stars 3 forks source link

Feat: Support Icon Shortcodes #1

Closed aidenlx closed 2 years ago

aidenlx commented 2 years ago

Hi! First of all, great work on Link Favicon! I'm the dev of Icon shortcodes plugin, which provides Font Awesome, Remixicon icons out of the box, and allow user to import any custom icon they have. Adding support for icon shortcodes would help user a lot in case they need to use their custom icons.

You can check here for details about its api: https://github.com/aidenlx/obsidian-icon-shortcodes#for-developer, and feel free to ask if you have any question :)

joethei commented 2 years ago

Hi, first of all thank you for this suggestion.

From your type def I don't seem to be able to get a list of all icon names, which would be helpful for building a suggestion for configuring these icons.

aidenlx commented 2 years ago

indeed, my plugin have an EditorSuggest modal working in editor that would suggest shortcodes with fuzzy search when typing :, but that won't work on regular <input> element. For now, maybe you can add a input box that only validate the shortcode and let user to get desired icon shortcode from editor. I'll expose some modal that would work outside of editor, but it may take some time

joethei commented 2 years ago

sure, going to implement this once v0.13 of obsidian has been released to the public(I am not an insider)

aidenlx commented 2 years ago

Good news! obsidian v0.13+ is publicly available for test and icon shortcode plugin is now available in the community plugin list. No rush if you don’t have time though, just sharing the news.

joethei commented 2 years ago

This is now available, if your plugin is also installed.

aidenlx commented 2 years ago

From your type def I don't seem to be able to get a list of all icon names, which would be helpful for building a suggestion for configuring these icons.

since v0.6.1, a new method getIconFromUser can open a modal to prompt user for icon selection. (make sure to check if it's available before calling it btw, you can do this by checking plugin version)

joethei commented 2 years ago

This is now implemented in v1.4.0