joethei / obsidian-link-favicon

See the favicon for a linked website.
GNU General Public License v3.0
89 stars 3 forks source link

1.6.3 breaks dataview #12

Closed chrisgrieser closed 2 years ago

chrisgrieser commented 2 years ago

https://user-images.githubusercontent.com/73286100/154842900-d3cafd37-2402-432f-ab66-0138d2a63298.mov

joethei commented 2 years ago

This is interesting. I see that you use links inside the tasks. What is the format for those?

chrisgrieser commented 2 years ago

normal markdown links? or what do you mean? []()

joethei commented 2 years ago

Yeah, that is what I meant, since I could not reproduce this previously.

Does the dataview result show up after a bit? I was just away from the computer for a moment, and now they are there.

chrisgrieser commented 2 years ago

nope, stays that way for me :(

chrisgrieser commented 2 years ago

well, 1.4.4 is the last release that doesn't break anything for me? Strange. 🤔

joethei commented 2 years ago

You are still on the normal non insider build right?

chrisgrieser commented 2 years ago

yeah:

macOS 12.0.1
Obsidian 0.13.23
joethei commented 2 years ago

That makes this even stranger, The plugin still does it's job on normal files?

chrisgrieser commented 2 years ago

well, I haven't been only on 1.6.3 too long yet, but I didn't notice any other issue. Also, the problem didn't occur with 1.5.0 I think

joethei commented 2 years ago

I am not sure if this is even triggered by my plugin, but your recording does make it look so. I disabled all plugins but dataview but the issue persists. Very strange,😵

https://user-images.githubusercontent.com/7150512/154857058-990d0647-ea53-4caf-a1ff-9fcfb6212b73.mp4

(I did stop the recording before the last query has even been rendered)

NomarCub commented 2 years ago

Probably related to #14. It breaks for me the same way, also on Obsidian 0.13.23, on Windows.

NomarCub commented 2 years ago

This and #14 works for me now in the latest Obsidian version, v0.13.33.

chrisgrieser commented 2 years ago

can confirm, newest version does not break the plugin anymore.

joethei commented 2 years ago

Since this seems to be fixed for some reason, I am closing this issue.