search

joethei / obsidian-link-favicon

See the favicon for a linked website.
GNU General Public License v3.0
89 stars 2 forks source link

Icons don't load #31

Closed NomarCub closed 2 years ago

NomarCub commented 2 years ago

A lot of (sometimes most) links don't have favicons. There's also some error messages on the dev console when I scroll the problematic notes, probably related to problem:

image

I haven't managed to reproduce it consistently, but I can provide more observations if that helps.

NomarCub commented 2 years ago

The file in the error message exists, so I'm not sure what the problem is. @joethei could you help me debug this?

NomarCub commented 2 years ago

There's also this error:

image

@joethei could you help me debug this? Are there any pointers you could give?

joethei commented 2 years ago

Does the folder exist? Does the file exist?

I haven't found the cause of this yet, but I did fix the latest error, available in the next release. Available once I find the other issue.

NomarCub commented 2 years ago

Yes, they both exist. I found references to ctime in the code, but I don't know where I would need to look for the uncaught error in a promise.

joethei commented 2 years ago

I found references to ctime in the code, but I don't know where I would need to look for the uncaught error in a promise.

I already fixed that bug, available in the next update.