Icon is not displayed in live preview & source modes

[KkEi34]

Windows 10.0.19045 x64 Obsidian 1.1.16 (Installer v.0.15.9) Link Favicons 1.8.1

Steps to reproduce:

1. Create empty vault
2. Install & activate plugin
3. restart obsidian
4. create note
5. add link [issues](https://github.com/joethei/obsidian-link-favicon/issues) Result: Icon is displayed only in reading mode (see image below) Expected: Icon is displayed in reading, live preview and source mode.

[liuke101]

I had the same problem

[meinCF]

I had the same problem.

[tdcqin]

I had the same problem

[iljapanic]

Same here. Still haven't found a way to fix it.

[NomarCub]

@joethei do you plan on spending time on this plugin any time soon? Would you accept pull requests, or others forking or taking over? I rely on this functionality for day to day use, and it's really annoying to have this spotty functionality.

[joethei]

Feel free to send a PR, I haven't been able to find a fix for this yet

[hy4l]

I have the same issue. I use Win11pro Version 22H2 (0S Build 22621.1992). I also reported issues with ProZen plugin in case if it's related or somebody will find a connection between issues and OS.

My plugins are:

[
  "obsidian-image-toolkit",
  "folder-note-plugin",
  "obsidian-prozen",
  "obsidian-upcoming",
  "obsidian-tagfolder",
  "tag-wrangler",
  "settings-search",
  "obsidian-admonition",
  "obsidian-banners",
  "cmdr",
  "cycle-through-panes",
  "dataview",
  "cm-editor-syntax-highlight-obsidian",
  "emoji-shortcodes",
  "excalibrain",
  "obsidian-excalidraw-plugin",
  "obsidian-file-color",
  "obsidian-file-path-to-uri",
  "highlightr-plugin",
  "homepage",
  "obsidian-icon-folder",
  "obsidian-note-autocreator",
  "obsidian-plugin-update-tracker",
  "recent-files-obsidian"
] 

Many thanks, hyal

[hy4l]

I tested 1.8.2, different vaults and sandboxes and it doesn't fix on W11 Obsidian 1.14.12. The same issue:

[nhan000]

1.8.1 worked fine but after updating to 1.8.2, the plugin only works in Reading mode (sandbox vault). Obsidian 1.4.12, Windows 11.

[NomarCub]

Live preview completely broke for me too.

[mii-key]

Unfortunately doesn't work. Windows 11 x64 Obsidian 1.4.12 Link Favicons 1.8.2

[joethei]

I can't reproduce this, now I am confused. Can any of you run app.plugins.plugins['link-favicon'].isUsingLivePreviewEnabledEditor() in the dev console and post here what it returns?

[KillyMXI]

A line with a link in Live Preview:

When opening a page, I get this uncaught error in console:

Click to show

``` plugin:link-favicon:7 Uncaught (in promise) undefined p @ plugin:link-favicon:7 Promise.then (async) m @ plugin:link-favicon:7 eval @ plugin:link-favicon:7 I @ plugin:link-favicon:7 updateAsyncDecorations @ plugin:link-favicon:7 l @ app.js:1 c @ app.js:1 setTimeout (async) c @ app.js:1 setTimeout (async) u @ app.js:1 buildAsyncDecorations @ plugin:link-favicon:7 eval @ plugin:link-favicon:7 (anonymous) @ app.js:1 e.update @ app.js:1 e.setState @ app.js:1 t.set @ app.js:1 t.set @ app.js:1 t.setViewData @ app.js:1 t.setData @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 a @ app.js:1 Promise.then (async) l @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.loadFileInternal @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.onLoadFile @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.onLoadFile @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.loadFile @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.setState @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.setState @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 a @ app.js:1 Promise.then (async) l @ app.js:1 a @ app.js:1 Promise.then (async) l @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.setViewState @ app.js:1 eval @ plugin:obsidian-excalidraw-plugin:79 r @ plugin:obsidian-excalidraw-plugin:79 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.openFile @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 t.onFileClick @ app.js:1 s @ enhance.js:1 ``` 

[joethei]

Also can you try and see if 1.8.3 fixes this?

[KillyMXI]

1.8.3 shows the favicons. No uncaught error in console.

The console.log you've left in the code dumps a lot of garbage to console. Besides the links like this:

it also dumps code blocks there for some reason...

They are not broken, fortunately. But I don't think this extension supposed to touch them in any way.

[hy4l]

Also can you try and see if 1.8.3 fixes this?

[nhan000]

1.8.3 works for me.

[mii-key]

1.8.3 works. Great job! Thanks!