joethei / obsidian-plantuml

Generate PlantUML Diagrams inside Obsidian.md
MIT License
368 stars 18 forks source link

Could relative path to local .jar file be accepted in this plugin? #29

Closed zhang-stephen closed 2 years ago

zhang-stephen commented 2 years ago

Is your feature request related to a problem? Please describe.

plantuml.com is blocked by firewall of my workplace, so I have to download plantuml.jar to render plant UML codes.

Describe the solution you'd like

I just want know, could the relative path of plantuml.jar be accepted? e.g. the ./tools/plantuml.jar, and ./ means the root path of current vault of obsidian. or the absolute path is <vault>/tools/plant.jar?

I tried this but not worked. and I have read you code and found that local jar has higher priority than server URL.

Describe alternatives you've considered

I have no alternative method except use absolute path.

Additional context

zhang-stephen commented 2 years ago

I have opened PR #30, to solve this problem.