improvement for option `Local JAR`

joethei / obsidian-plantuml

Generate PlantUML Diagrams inside Obsidian.md

MIT License

395 stars 23 forks source link

improvement for option `Local JAR` #30

Closed zhang-stephen closed 2 years ago

zhang-stephen commented 2 years ago

[+] support path with unix-like style on windows,
e.g. ~/.local/plantuml.jar
[+] search plantuml.jar from current vault path, instead of __dirname
exported from obsidian

zhang-stephen commented 2 years ago

will it be merged?

joethei commented 2 years ago

probably, will need to do some more tests if this works as intented.

joethei commented 2 years ago

Your method does work for the most part, with one issue: It does not search relative to the vault path, but relative to the currently opened file inside the vault. I will merge this and fix that issue myself, since I already have that figured out.