joethei / obsidian-tagcloud

Show a cloud of your tags/words/links in a note
GNU General Public License v3.0
51 stars 3 forks source link

stopwords not working #5

Closed fabionolasco closed 11 months ago

fabionolasco commented 2 years ago

Hi there,

First, thank you for the plugin! Super cool!

I am using version 1.3.1 with Obsidian version 0.13.23

I added one word per line on the stopwords field on the options part of the TagCloud plugin, like so: the a on in that is to for do our will would should could from and if this these those with as may therefore but are there if

I also tried to force it by adding the stopword: true

  ```wordcloud
  source: file
  stopwords: true

and

  source: file


The tag cloud shows up, but the stopwords also show up.

I already tried to close and reopen Obsidian.
I already tried to delete the text and re-add it.

Any ideas what could be wrong?

Thank you!
joethei commented 2 years ago

Version 1.3.2 has fixed an issue where custom stopwords would not be applied. Please keep in mind that you will need to recalculate the word distribution everytime you change anything in the settings and after updating to that version. There is a command as well as a button in the settings. (The frequency analysis can take a long time, so not automatic.)

kauffy commented 2 years ago

@joethei I'm using 1.3.2, and not only are the stopwords not used, the word cloud seems to be almost only the stopwords! It also seems that changing any of the options has no effect on the word cloud (it's too small, and it doesn't change from generation to generation)-- the other clouds (tag, link) seem to respond as expected, but the word cloud seems to be deterministically wrong. I have had it recalculate the word distribution a bunch of times, but same result.

wordcloud
stopwords = true
width = 800
height = 600
maxDepth = 50

Stop words: image

Yields: image

Recalculating word distribution, then:

image

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 2 years ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

berot3 commented 2 years ago

Hey, I also wanted to report that it doesn't remove stop words for me (v1.3.2)

I tried

    ```wordcloud
    source: file

and 
```wordcloud
source: file
stopwords: true
```


produces:

![image](https://user-images.githubusercontent.com/52616/173780860-adb0f8ad-c4f2-4bb9-8e7a-bab82b4e594c.png)
berot3 commented 2 years ago

So sorry, after copy/pasting this: https://github.com/igorbrigadir/stopwords/blob/master/en/terrier.txt into the plaugin-settings it works like a charm. I somehow assumed that they were already added by default. oops!

tekiegirl commented 2 years ago

Loving this plugin, except that I have this stopword problem too, using v 1.3.2 of this plugin with Obsidian 0.14.15

I have

Many thanks for your work on this.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 30 days with no activity.

leodking commented 2 years ago

Hi, I wanted to report I'm having the same issues as the others. Love the idea of this plugin, but unfortunately it only shows me stopwords right now, despite defining these in the custom list. I've recalculated the vault several times.

image

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

tekiegirl commented 1 year ago

This is still an issue for me. Not sure if it has been fixed since the last release, but I know that my bug fix for another issue has not been released yet (as of Oct 21 '22) as I have to manually apply it to the code in my vault 😉 If I have time I will try to debug this one too.

joethei commented 1 year ago

yeah, It's still an issue, I am not always fast enough to stop the bot from closing the issue.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

irasanchez commented 1 year ago

@joethei did you want some help on this? I know it's been a while, so no pressure if you've moved on and are over it. It's just the only plugin that really provides a feature like this. If you'd prefer that I fork and tinker on my own, that's fine too. Whenever you have some time, let me know your preferences.

Thanks for making this!