search

joetsoi / OpenMoonstone

Open source reimplementation of Moonstone: A Hard Day's Knight
GNU Affero General Public License v3.0
69 stars 4 forks source link

Make sure openmoonstone and ggez-goodies relies on same version of ggez #3

Closed Bhaal22 closed 4 years ago

Bhaal22 commented 4 years ago

Without this "fix" , ggez is in conflict with usage in ggez-goodies. A smarted fix, to my opinion should be to have a fixed version in ggez-goodies and in openmoonstone.

joetsoi commented 4 years ago

Thanks for this! I didn't think anyone would actually be building this apart from me yet. This was required whilst there was a bug in ggez 0.5 rc releases.

I'll be a more careful about making sure master is in a buildable state from now on.

Bhaal22 commented 4 years ago

I am a big fan of Moonstone back to 90s when I was 10 :) Will try to contribute the more I can and Rust is my current learning.

joetsoi commented 4 years ago

Ah, I know what's going on here. My fork of ggez-goodies is out of date, I've pushed an updated version for now, but the real fix is to use the official ggez-goodies instead of maintaining a fork. This will mean changing the FadeIn/FadeOut transition scenes. see (https://github.com/joetsoi/OpenMoonstone/issues/4)