Added automaticOpen option. Determines whether or not the socket will be...

Jakobud commented 9 years ago

Added automaticOpen (true/false) option. Determines whether or not the socket will be created and connect automatically upon instantiation or not.
Also changed function connect() to publicly available open(). Now the user can manually close() and open() the connection if they desired to.
Also changed the open() function to use self.url instead of url, allowing a user to change the url if they want. So a user could close(), then change the URL to another websocket URL, then open(). Ultimately a user would most likely just create a different ReconnectingWebSocket instance as that is a better solution and a better practice anyways, but this option was easy to add and probably a good idea to have in there now that a user can manually open() and close() the connection at will.
Backwards compatibility is maintained with these changes, as automaticOpen is true by default which is the current behavior.

joewalnes commented 9 years ago

Code looks good. Can you beef up the docs in the header and README to explain this.

Jakobud commented 9 years ago

Done!

joewalnes commented 9 years ago

Awesome. I'm seeing some merge conflicts. Can you make sure you are up to date with origin master.

Jakobud commented 9 years ago

I think I fixed the merge conflicts. Good to go I think!

joewalnes commented 9 years ago

Merged, thanks!

joewalnes / reconnecting-websocket