search

joewalnes / reconnecting-websocket

A small decorator for the JavaScript WebSocket API that automatically reconnects
MIT License
4.22k stars 968 forks source link

stop reconnecting after close() is called #8

Closed relekang closed 10 years ago

relekang commented 11 years ago

If close() is called when the websocket connection is down it should not try to reconnect. There are at least two reasons to avoid this. It should not send a lot of unnecessary requests and if it is able to reconnect the connection will go live again even if the application using reconnecting-websocket tried to close it.

pablocaselas commented 10 years ago

+1 .Thanks @relekang for the fix :+1:

Why isn't this pull request accepted yet?

joewalnes commented 10 years ago

Thanks! It got lost somewhere in my inbox. Merged now :)

pablocaselas commented 10 years ago

Cool. Thanks @joewalnes!

anhzhi commented 6 years ago

@joewalnes
time to update the README.md