search

joewalnes / smoothie

Smoothie Charts: smooooooth JavaScript charts for realtime streaming data
http://smoothiecharts.org
Other
2.25k stars 234 forks source link

Display Series Label in Tooltip #107

Closed jackdesert closed 6 years ago

jackdesert commented 6 years ago

Specify a Label When Adding a Series

This PR allows the user to optionally specify a label when adding a series:

var series_1 = new TimeSeries()
smoothie.addTimeSeries(series_1, { tooltipLabel: 'series-1' })

And that label will be displayed along with the numerical value in the tooltip.

drewnoakes commented 6 years ago

Please update smoothie.d.ts with the API change.

jackdesert commented 6 years ago

Added a new commit that updates smoothie.d.ts

drewnoakes commented 6 years ago

Please also update the function's API doc:

https://github.com/joewalnes/smoothie/blob/648336c48d3e0e7b11a9fa2f4b514d63973f57f8/smoothie.js#L427-L440

Also, add your contribution to the header under version 1.36:

https://github.com/joewalnes/smoothie/blob/648336c48d3e0e7b11a9fa2f4b514d63973f57f8/smoothie.js#L90

jackdesert commented 6 years ago

Added option to API docs, and added my username to the contribution.

drewnoakes commented 6 years ago

Thanks!