Sizing issues with Retina MacBook

joewalnes / smoothie

Smoothie Charts: smooooooth JavaScript charts for realtime streaming data

http://smoothiecharts.org

Other

2.25k stars 232 forks source link

Sizing issues with Retina MacBook #44

Closed chriscareycode closed 10 years ago

chriscareycode commented 10 years ago

The canvas seems to double in size and the max/min numbers are off the canvas on Retina displays. This can be seen simply by visiting http://smoothiecharts.org/ on a Retina Mac.

chriscareycode commented 10 years ago

Commenting out the section at line 418 fixed my issue and the charts look ok. // Make sure the canvas has the optimal resolution for the device's pixel ratio.

drewnoakes commented 10 years ago

Thanks for the report. This bug got through because I don't have a retina screen to test on :)

It seems the problem is one of CSS styling. On high-DPI displays, we adjust the canvas width and height attributes, yet if the corresponding CSS width and height are not populated with the original values, then the canvas will appear larger than usual.

I'll look into this issue further now.

drewnoakes commented 10 years ago

Fixed in version 1.23.

Tested on a friend's retina screen and seems ok.

Thanks for the bug report.

eeve commented 6 years ago

@drewnoakes @joewalnes

In response mode, this bug still exists