search

joewing / jwm

Joe's Window Manager
http://joewing.net/projects/jwm
MIT License
520 stars 84 forks source link

Closes #575 Add window title match support in Group config section #576

Closed BertranAsylum closed 2 years ago

BertranAsylum commented 2 years ago

Now you can specify "Title" match in "Group" section:

<Group>
    <Title>Some window title</Title>
    <!-- ... -->
</Group>
BertranAsylum commented 2 years ago

My bad, duplicates #519

joewing commented 2 years ago

It appears that I'm fighting a losing battle with this one 😄 Because the title can change and may not even be set when the window is mapped, I tend to think it's a bad idea to use the window title for matching. On the other hand, this particular thing has been implemented twice before (PRs #265 and #519) and it's been requested at least three times now (issues #234, #416 and now #575). So I'm thinking I may just let this go through (I might just update the documentation at some point to reflect the fact that this match only runs when the window initially appears). I guess the question is which PR... The three PRs are very similar, but all use a different name for the tag. Though I have to admit, I like "Title" the best!

BertranAsylum commented 2 years ago

It appears that I'm fighting a losing battle with this one 😄 Because the title can change and may not even be set when the window is mapped, I tend to think it's a bad idea to use the window title for matching. On the other hand, this particular thing has been implemented twice before (PRs #265 and #519) and it's been requested at least three times now (issues #234, #416 and now #575). So I'm thinking I may just let this go through (I might just update the documentation at some point to reflect the fact that this match only runs when the window initially appears). I guess the question is which PR... The three PRs are very similar, but all use a different name for the tag. Though I have to admit, I like "Title" the best!

What about title changes monitoring and remap if title match. Probably, more wasteful than useful..

joewing commented 2 years ago

Thanks! I went ahead and merged this one. Probably fine as is without making it more complicated.