joewing / jwm

Joe's Window Manager
http://joewing.net/projects/jwm
MIT License
520 stars 84 forks source link

Vertical Gradient #591

Closed BlackCodec closed 1 year ago

BlackCodec commented 1 year ago

Hello, I wrote the code to get the vertical gradient, or rather horizontal.

vgradient.code.txt

Also based on what I've seen in the other window managers the current implementation looks like a vertical gradient rather than a horizontal one. I read the code I suppose you defined it horizontal because of the way you draw it (line by line from bottom to top) but it is a little misleading.

However this is the vertical gradient method, i.e. the gradient from left to right.

It only remains to add an option in the configuration file so that it is possible to specify the type of gradient to use (vertical or horizontal).

I would suggest turning it on for windows only because I tested and written it for that context only.

I hope it will be useful to you, I'm sorry but I have not found where you analyze the configuration file otherwise I would have directly suggested that change too.

Thanks again for the great work.

BlackCodec commented 1 year ago

Hello, I found all required information and do a pull request: Add support for draw horizontal or vertical gradient #592

Thanks.