search

joewledger / Green_Labs_Plotting

A desktop application to create customizable visualizations from energy sensor data
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Reorganize Light and Occupancy Pie Chart Plotters #15

Open joewledger opened 8 years ago

joewledger commented 8 years ago

Rewrite the lighting and occupancy pie chart plotters so that they both inherit from a new class, 'Generic_Pie_Chart_Plotter'. This will have two benefits.

  1. Separate plotting logic from data generation logic.
  2. Make it easier to create future pie chart visualizations (simply subclass Generic_Pie_Chart_Plotter)!
joewledger commented 8 years ago

The problem of data generation logic popping up in the plotting functions happens in several places in the code. This should be removed. A short (possibly incomplete list of the places that this happens is below):

  1. Light_Occupancy_Pie_Chart_Plotter
  2. Light_Occupancy_Pie_Chart_Quad_Plotter
  3. Generic_Hourly_Average_Plotter
  4. Generic_Scatter_Plotter