joeyajames / Python

Python code for YouTube videos.
MIT License
1.64k stars 1.35k forks source link

Update HexToDec.py #135

Open nikitapandeyy opened 1 year ago

nikitapandeyy commented 1 year ago

The code has a few issues:

The getDecDigit() function is unnecessarily defined as a private function. Since it is not a method of a class, it can simply be defined as a regular function. The getDecDigit() function can be simplified by using the index() method of a list to find the index of the given digit. The hexToDec() function is not returning the decimal number, it is only printing it. It should be modified to return the value instead. The loop in the hexToDec() function is iterating over the length of the hex number in reverse order. This is unnecessary and can be simplified to a regular forward loop.