search

joeyaurel / python-gedcom

Python module for parsing, analyzing, and manipulating GEDCOM files
https://gedcom.joeyaurel.dev
GNU General Public License v2.0
154 stars 39 forks source link

Fix for to_gedcom_string() #29

Closed KeithPetro closed 4 years ago

KeithPetro commented 5 years ago

Fix for #27. This should fix an issue where calling to_gedcom_string() for the ROOT element resulted in an empty string. Recursion was also broken and has been fixed.

KeithPetro commented 5 years ago

Looks like the Travis build failed. I'll look into that as soon as I am able to get on my computer again.

gburca commented 4 years ago

Any plans to merge this in?

KeithPetro commented 4 years ago

Looking over my changes quickly, I think it would've been smarter to just return result instead of returning ''. I think there is an issue with this change, as there is no base return condition if recursive is True. I don't know how I missed that in my original testing.

mameen commented 4 years ago

identical fix + test cases : https://github.com/mameen/python-gedcom/commit/9fcd8944090f2ade764a44d638fcac9e26dde8c5

KeithPetro commented 4 years ago

Hey @nickreynke, any chance of getting this merged in?

@mameen If you're good with it, I can either add you as a contributor to my fork so you can push your tests to this PR, or I could push the tests myself.

mameen commented 4 years ago

@KeithPetro you are welcome to cherrypick the fix from my fork.. I lost interest in the project :-D

joeyaurel commented 4 years ago

@KeithPetro and @mameen: I'm very sorry for the late reply. Due to some private problems, I experienced the last months, I didn't get the time to maintain the project. I'll publish a new version to Pypi later this day. Thank you for contributing!

mameen commented 4 years ago

@nickreynke I hope things are good now, and thanks for looking after this project.