search

joeyaurel / python-gedcom

Python module for parsing, analyzing, and manipulating GEDCOM files
https://gedcom.joeyaurel.dev
GNU General Public License v2.0
160 stars 39 forks source link

fix(parser.py): remove call to deleted method is_family() #56

Closed joephayes closed 4 years ago

joephayes commented 4 years ago

I think this will resolve https://github.com/nickreynke/python-gedcom/issues/55

joeyaurel commented 4 years ago

Seems about right. Was thinking about if if is_family: could have been just replaced by a isinstance(individual, FamilyElement) but this is also okay for the time being.

Thank you for your contribution! Will close this :)

joeyaurel commented 4 years ago

Hey @joephayes sorry for the inconvenience. Thought you selected the master branch as the main branch so I were able to instantly release a new version but you selected develop. The develop branch currently has way more commits than the master branch so I wouldn't be able to release that yet.

If you could re-open this pr with the master branch selected as the base branch?

Thank you!

joephayes commented 4 years ago

No worries! Opened a new PR against master - https://github.com/nickreynke/python-gedcom/pull/58

joeyaurel commented 4 years ago

Thank you! Resolved in #58