search

joeyaurel / python-gedcom

Python module for parsing, analyzing, and manipulating GEDCOM files
https://gedcom.joeyaurel.dev
GNU General Public License v2.0
155 stars 39 forks source link

Bugs with get_name and get_marriages #9

Closed damonbrodie closed 5 years ago

damonbrodie commented 5 years ago

I've created a PR (#8) that addresses the following bugs:

1) get_marriages. This method returns a Tuple that has the date and location. It was being assembled incorrectly. If there was a single marriage on Oct 5, 2000 in location Canada, then it was returning two marriages one with date="Oct 5, 2000", location="" and a second marriage with date="", location="Canada".

2) get_name was iterating through all the NAME records and returning the last one found. Typically the first NAME record is the "preferred" record, and it should be what is returned with get_name

joeyaurel commented 5 years ago

8 merged! Creating a new tag now :)

joeyaurel commented 5 years ago

@nomadyow version v0.2.3dev is up. Thank you!