search

joeybaker / remapify

Alias directories for browserify
Other
117 stars 23 forks source link

browserify _extensions taken into account #4

Closed nullpotent closed 10 years ago

nullpotent commented 10 years ago

Fixes issue #3

nullpotent commented 10 years ago

Entschuldigung, I have 0 experience with all of this. This commit opened another issue as if it is a real one; which is strange to me, is this expected? How should I commit next time around?

joeybaker commented 10 years ago

Thanks @iccthedral. Here's the way GH does this:

When you open a PR, it creates a new issue. That's intentional.

Your PR description should include something about what you did, and the comment "fixes #" for an issue. (Which you did!)

I've reopened this PR, and will take a look tonight. When I merge it, it'll close the issue for us and the PR.

JohnRandom commented 10 years ago

Hey guys, how is this coming along? Can I do anything to help? I could really use the patch right about now :)

joeybaker commented 10 years ago

@iccthedral any thoughts on my feedback?

nullpotent commented 10 years ago

@joeybaker Yes, but can you guys wait for just one more day. I'm on vacation atm.

JohnRandom commented 10 years ago

Any progress on this issue? I'm still willing to help out..

nullpotent commented 10 years ago

@JohnRandom Sure, do you understand the problem I'm having? @joeybaker's comments are all spot on except I think on remapify:patterns event... so, could you please comment on my PR as well? Maybe I did something wrong.