search

joeycastillo / Sensor-Watch

A board replacement for the classic Casio F-91W wristwatch
Other
1.03k stars 210 forks source link

add compile-time options for all preferences to movement_config #295

Closed madhogs closed 4 months ago

madhogs commented 9 months ago

PR to add compile-time options for all preferences to movement_config.h. I have set the values to match all currently existing defaults.

This will allow the user to omit the preferences face if they wish and define all options at build time. Addresses issue - https://github.com/joeycastillo/Sensor-Watch/issues/291 (some of it at least)

matheusmoreira commented 4 months ago

Am now running this code on real hardware. Used it to set 24h as default. Worked. No issues.

madhogs commented 4 months ago

@matheusmoreira That's great to hear, thanks for looking at this. Let me know if there is anything more needed to merge this in.

matheusmoreira commented 4 months ago

Let me know if there is anything more needed to merge this in.

I think the upstream maintainers are reviewing it right now. I'm looking forward to it.

In any case, it's already been merged into my branch¹ along with several other pull requests. I'm running that branch on my watch with no issues so far. You're welcome to use it if you'd like!

814d3 commented 3 months ago

@madhogs, since there are "instant" LED activation and 10 min. LE timeout, there need to be some additions in your code, right? I'm not so familiar with this, so just a note.

madhogs commented 3 months ago

@814d3 yes, this was merged after the 10min timeout option was merged and unfortunately needs changing. I have adjusted the options in my next pr here https://github.com/joeycastillo/Sensor-Watch/pull/387 . This fixes the comment and puts the default back to 1 hour. The instant option hasn't been merged yet (i'm pretty sure) so it should be correct in my latest PR. If that does get merged first i will update my pr.