joeycastillo / Sensor-Watch

A board replacement for the classic Casio F-91W wristwatch
Other
1.03k stars 210 forks source link

Comment all the things #297

Closed ooterness closed 7 months ago

ooterness commented 9 months ago

Fix missing or inconsistent documentation for many clock faces:

This PR should be 100% comment changes only, no functional impact whatsoever.

ooterness commented 9 months ago

Sometime soon, I'll go and resync new comments here with what's available on the wiki.

Update: IT IS DONE

ooterness commented 9 months ago

@josecastillo : This has been open for a few days now. Any comments or concerns?

tahnok commented 8 months ago

Beats, totp face are MIT licensed

On Sun, Nov 19, 2023, 13:16 mrbrown8 @.***> wrote:

@.**** commented on this pull request.

In movement/watch_faces/clock/beats_face.c https://github.com/joeycastillo/Sensor-Watch/pull/297#discussion_r1398470105 :

@@ -1,3 +1,27 @@ +/*

    • MIT License

Thank you for asking, but I did NOT write this code. I cannot take credit/blame for this.

— Reply to this email directly, view it on GitHub https://github.com/joeycastillo/Sensor-Watch/pull/297#discussion_r1398470105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYSEKSR2ETC3XS6L4FXMLYFJEHNAVCNFSM6AAAAAA5QR36SWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZYGY4TQOBYHA . You are receiving this because you were mentioned.Message ID: @.***>

ooterness commented 8 months ago

@tahnok has confirmed MIT license is correct for Beats and TOTP. That leaves Discgolf, TOTP-LFS, and Wyoscan.

I'll leave this as-is for a few days in case those authors respond. If not, I'll revert the changes to those faces so we can move forward. I can open a separate issue to get copyright questions straightened out.

ooterness commented 7 months ago

I've reverted the remaining unconfirmed copyright-related changes. (i.e., Discgolf and Wyoscan.)