search

joeycastillo / Sensor-Watch

A board replacement for the classic Casio F-91W wristwatch
Other
1.17k stars 233 forks source link

TOTP no longer works as of 2 January 2024 #348

Closed matthewcmead closed 8 months ago

matthewcmead commented 9 months ago

I've had working a totp face since February 2023. I haven't used the watch in a couple weeks for totp, and much to my surprise, it doesn't work today. I've validated with another totp generator which has the same seeds that the values the watch is producing are different. I used the watch for totp successfully three weeks ago. The timezone is still set the same and the time is synchronized.

Any idea what might be going on? Nothing's changed with the watch -- it's been sealed since I installed the firmware last February.

Thanks!

tahnok commented 9 months ago

I think there was a bug in the timestamp calculation that was fixed, you may want to see if upgrading your firmware fixes it

On Tue, Jan 2, 2024, 17:43 matthewcmead @.***> wrote:

I've had working a totp face since February 2023. I haven't used the watch in a couple weeks for totp, and much to my surprise, it doesn't work today. I've validated with another totp generator which has the same seeds that the values the watch is producing are different. I used the watch for totp successfully three weeks ago. The timezone is still set the same and the time is synchronized.

Any idea what might be going on? Nothing's changed with the watch -- it's been sealed since I installed the firmware last February.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/joeycastillo/Sensor-Watch/issues/348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYSEKQOEIPN7UUV67THQTYMSESHAVCNFSM6AAAAABBKUJLCGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DGMBTG42DEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

matthewcmead commented 9 months ago

That did it. Thanks! Please feel free to close the issue.

joeycastillo commented 9 months ago

I’d like to leave this issue open until I address it in the posted firmware images on sensorwatch.net

thanks so much to everyone for reporting and recognizing the issue!

EmilienCourt commented 9 months ago

For completeness (and since I encountered this issue myself), this bug occurred on the 1st January of 2024, since it's a leap year and (as @tahnok pointed out) there was a bug in the timestamp calculation for those years.

The bug was raised here and fixed here

joeycastillo commented 8 months ago

Thanks so much to everyone for identifying and addressing this bug, and sorry for being asleep at the wheel deploying the fix. As mentioned, this bug has been fixed in main; you will need to rebuild and reflash your board to get the fix.

I've also updated all the prebuilt firmware images on sensorwatch.net; while none of these firmware images contained the TOTP function, some contained timers and countdowns that were affected. Reflashing with an updated firmware image should address the issue folks were seeing as we entered this leap year.