Revert "make the watch-face a global in movement.c, actually"

joeycastillo / Sensor-Watch

A board replacement for the classic Casio F-91W wristwatch

Other

1.02k stars 210 forks source link

Revert "make the watch-face a global in movement.c, actually" #362

Closed Kistelini closed 5 months ago

Kistelini commented 5 months ago

This reverts commit 0e801ed505cb0c368bf1eb0473058efb6c275a3e.

This commit breaks the firmware on my watch (although it works in the simulator), the display doesn't show anything after reassembly. Maybe others can confirm this!

wryun commented 5 months ago

It's declared as a const... this seems wrong. Presumably in the compiled version for the watch it's being put in a read-only place (but works in sim because no place is read only). Would have thought compiled would be complaining a lot.

Might be worth checking exactly what lead up to this. I'm also a bit dubious about 'wf' being pulled out at all, because theoretically someone could change the current face at various places in the app loop.

theAlexes commented 5 months ago

ah yeah we forgot to edit the const out when moving that line up. im not sure how it worked on my watches.

theAlexes commented 5 months ago

Anyway yeah, if changing watch faces inside the main loop is valid, then this change isn't, revert away 👍