Added day display in twelve different languages

joeycastillo / Sensor-Watch

A board replacement for the classic Casio F-91W wristwatch

Other

1.02k stars 210 forks source link

Added day display in twelve different languages #402

Closed renaudrenaud closed 1 month ago

renaudrenaud commented 1 month ago

Added support for displaying the days of the week in 13 languages:
1 - English (EN) - United Kingdom, United States, etc.
- 2 - Spanish (ES) - Spain, Mexico, etc.
- 3 - French (FR) - France, Canada, etc.
- 4 - German (DE) - Germany, Austria, etc.
- 5 - Italian (IT) - Italy, Switzerland, etc.
- 6 - Portuguese (PT) - Portugal, Brazil, etc.
- 7 - Dutch (NL) - Netherlands, Belgium, etc.
- 8 - Danish (DA) - Denmark
- 9 - Swedish (SV) - Sweden
- 10 - Polish (PL) - Poland
- 11 - Finnish (FI) - Finland
- 12 - Norwegian (NO) - Norway
- 13 - Friday (FD) - Friday language (for fun, 13th Friday language, every day is Friday)
Tested and validated multilingual displays with the simulator

maxz commented 1 month ago

First of all you pushed your private configuration like the faces and the tune and so on. Please remove those.

Also someone was already working on this feature: #396.

After looking over the actual changes, I also don't like them to be honest. I think the rare space within movement_settings_t should be reserved for things which pretty much would have to happen at runtime like maybe timezone support. Adding the language as a compile time settings as seen in the other pull request seems like the superior approach to me.

renaudrenaud commented 1 month ago

Don't understand how this whole thing is working, sorry for wwasting your time.